feat(combobox): add comboBox component #454
Conversation
Tianhui-Han
changed the title
Understood, once I have fixed the aforementioned issues, I will notify you. Thank you for helping with the review. |
I have made modifications according to your suggestions. The unit test part is not yet complete and is still in progress. Could you please check if the current changes meet the expectations? Thank you! |
Accessibility issues that I raised look good. I've left some comments about parts of the implementation. Let me know when the unit tests are done and I'll have another look |
optimize component
Hey Jordan, I’ve completed these modifications and filled out the unit tests. |
Hey Jordan, I have made these changes, could you please review them again? Thank you for your continuous support, you are very patient!👍 |
| @@ -0,0 +1,26 @@ | |||
| import {IComboboxGroup, IComboboxItem} from './Combobox.types' | |||
There was a problem hiding this comment.
small: missing semi colon at end of line
src/components/Combobox/index.ts
Outdated
There was a problem hiding this comment.
Important: you need to add Combobox as one of the exports from ./components in the file in src/index.js otherwise you won't be able to use it in Cantina properly
I’ve made a small adjustment to the logic, making the interaction between selectionChange and inputValue more reasonable, and also improved the overall naming conventions. However, it seems that I don’t have the permission to merge. Could you please help me merge it? Thank you very much!👍 |
Tianhui-Han
changed the title
|
🎉 This PR is included in version 26.101.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
add a comboBox with input and select, inputValue is used to filter select list item